Skip to content

[Feature](fe) Add admin set partition version statement#23086

Merged
xy720 merged 6 commits into
apache:masterfrom
xy720:admin-set-partition-properties
Aug 28, 2023
Merged

[Feature](fe) Add admin set partition version statement#23086
xy720 merged 6 commits into
apache:masterfrom
xy720:admin-set-partition-properties

Conversation

@xy720

@xy720 xy720 commented Aug 17, 2023

Copy link
Copy Markdown
Member

Proposed changes

Last week, we encountered a situation where we had to recover master's metadata from image without bdbje log.
After recovering the master, we found that the partition visible version of the master's metadata was inconsistent with the actual replica in Be.

This commit add a statement to modify partition visible version.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@xy720

xy720 commented Aug 17, 2023

Copy link
Copy Markdown
Member Author

run buildall

@xy720

xy720 commented Aug 17, 2023

Copy link
Copy Markdown
Member Author

some docs still need to be updated

@xy720

xy720 commented Aug 18, 2023

Copy link
Copy Markdown
Member Author

run buildall

@hello-stephen

hello-stephen commented Aug 18, 2023

Copy link
Copy Markdown
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.74 seconds
stream load tsv: 536 seconds loaded 74807831229 Bytes, about 133 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.2 seconds inserted 10000000 Rows, about 342K ops/s
storage size: 17162140296 Bytes

morningman
morningman reviewed Aug 19, 2023
View reviewed changes

@morningman morningman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add regression test case.
Eg, if a partition's version is 3,

  1. set it to 2
  2. set it to 3
  3. check if table can query
  4. load some data
  5. check if table can query

Comment thread fe/fe-core/src/main/java/org/apache/doris/persist/SetPartitionVersionOperationLog.java Outdated
Comment thread fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java Outdated
@xy720 xy720 force-pushed the admin-set-partition-properties branch from d93946d to bc47cb5 Compare August 24, 2023 07:40
@xy720

xy720 commented Aug 24, 2023

Copy link
Copy Markdown
Member Author

run buildall

@xy720

xy720 commented Aug 24, 2023

Copy link
Copy Markdown
Member Author

run buildall

@hello-stephen

hello-stephen commented Aug 24, 2023

Copy link
Copy Markdown
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.13 seconds
stream load tsv: 542 seconds loaded 74807831229 Bytes, about 131 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.2 seconds inserted 10000000 Rows, about 342K ops/s
storage size: 17162305756 Bytes

@xy720

xy720 commented Aug 24, 2023

Copy link
Copy Markdown
Member Author

@morningman

@hello-stephen

hello-stephen commented Aug 24, 2023

Copy link
Copy Markdown
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.07 seconds
stream load tsv: 542 seconds loaded 74807831229 Bytes, about 131 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.5 seconds inserted 10000000 Rows, about 338K ops/s
storage size: 17161946626 Bytes

morningman
morningman previously approved these changes Aug 26, 2023
View reviewed changes

@morningman morningman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label Aug 26, 2023
@github-actions

github-actions Bot commented Aug 26, 2023

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actions Bot commented Aug 26, 2023

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

chenlinzhong
chenlinzhong previously approved these changes Aug 28, 2023
View reviewed changes

@chenlinzhong chenlinzhong left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xy720 xy720 dismissed stale reviews from chenlinzhong and morningman via bc448e8 August 28, 2023 02:24
@xy720

xy720 commented Aug 28, 2023

Copy link
Copy Markdown
Member Author

run buildall

@github-actions github-actions Bot removed the approved Indicates a PR has been approved by one committer. label Aug 28, 2023
@xy720

xy720 commented Aug 28, 2023

Copy link
Copy Markdown
Member Author

run clickbench

@hello-stephen

hello-stephen commented Aug 28, 2023

Copy link
Copy Markdown
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 47.97 seconds
stream load tsv: 536 seconds loaded 74807831229 Bytes, about 133 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17162209572 Bytes

chenlinzhong
chenlinzhong approved these changes Aug 28, 2023
View reviewed changes

@chenlinzhong chenlinzhong left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label Aug 28, 2023
@github-actions

github-actions Bot commented Aug 28, 2023

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

adonis0147
adonis0147 approved these changes Aug 28, 2023
View reviewed changes

@adonis0147 adonis0147 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xy720 xy720 merged commit 4c8fc06 into apache:master Aug 28, 2023
xiaokang pushed a commit that referenced this pull request Aug 30, 2023
@xy720 @xiaokang
[Feature](fe) Add admin set partition version statement (#23086)
5442d9a 
This commit add a statement to modify partition visible version.
morningman pushed a commit to morningman/doris that referenced this pull request Aug 31, 2023
@xy720 @morningman
[Feature](fe) Add admin set partition version statement (apache#23086)
27ed2c5 
This commit add a statement to modify partition visible version.
@xiaokang

xiaokang commented Sep 15, 2023

Copy link
Copy Markdown
Contributor

revert this PR in branch-2.0 since it modify fe metadata OperationType and cause rollback from 2.0.2 to 2.0.1/2.0.0

xiaokang added a commit that referenced this pull request Sep 15, 2023
@xiaokang
Revert "[Feature](fe) Add admin set partition version statement (#23086…
4cd6e66 
…)"

This reverts commit 5442d9a.
@mongo360 mongo360 mentioned this pull request Jun 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adonis0147 adonis0147 adonis0147 approved these changes
@chenlinzhong chenlinzhong chenlinzhong approved these changes
@morningman morningman morningman left review comments

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@xy720 @hello-stephen @xiaokang @adonis0147 @morningman @chenlinzhong